Loading...

Type: Improvement
Resolution: Fixed
Priority: Major
Fix Version/s: Future Release
Affects Version/s: Danube 3.0
Labels:
None

As part of the build process we now check pylint scores and if there is a failure the build fails. The issue is the build server runs Ubuntu and python34. This may not be consistent with user systems running these checks which creates a descrepency between scores. If the score fails there is no indication of what the error is. This Jira will track a patch to modify this to post the errors in the build output so users can fix their errors accordingly.

Example output....

Execution of pylint checks:
conf/_init_.py OK
core/component_factory.py OK
core/_init_.py OK
core/loader/_init_.py OK
core/loader/loader.py OK
core/loader/loader_servant.py OK
core/pktfwd_controller.py 9.76

- - - - Module core.pktfwd_controller
        core/results/_init_.py OK
        core/results/results_constants.py OK
        core/results/results.py OK
        core/traffic_controller.py OK
        core/traffic_controller_rfc2544.py OK
        core/traffic_controller_rfc2889.py OK
        ^C
        (vsperfenv)[root@netqe22 vswitchperf]# nano check
        (vsperfenv)[root@netqe22 vswitchperf]# ./check
        which: no bc in (/root/vsperfenv/bin:/opt/rh/python33/root/usr/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/root/bin)
        Execution of pylint checks:
        conf/_init_.py OK
        core/component_factory.py OK
        core/_init_.py OK
        core/loader/_init_.py OK
        core/loader/loader.py OK
        core/loader/loader_servant.py OK
        core/pktfwd_controller.py 9.76
        
        Module core.pktfwd_controller
        C: 98, 0: Trailing newlines (trailing-newlines)
        core/results/_init_.py OK
        core/results/results_constants.py OK
        core/results/results.py OK
        core/traffic_controller.py OK
        core/traffic_controller_rfc2544.py OK
        core/traffic_controller_rfc2889.py OK
        core/vnf_controller.py OK
        core/vswitch_controller_clean.py OK
        core/vswitch_controller_op2p.py OK
        core/vswitch_controller_p2p.py OK
        core/vswitch_controller_ptunp.py OK
        core/vswitch_controller_pxp.py OK
        core/vswitch_controller.py OK
        src/dpdk/dpdk.py OK
        src/dpdk/_init_.py OK
        src/dpdk/testpmd_proc.py OK
        src/_init_.py NA
        src/ovs/dpctl.py OK
        src/ovs/_init_.py OK
        src/ovs/ofctl.py OK
        testcases/_init_.py OK
        testcases/integration.py OK
        testcases/performance.py OK
        testcases/testcase.py OK
        tools/collectors/collector/collector.py OK
        tools/collectors/collector/_init_.py OK
        tools/collectors/_init_.py NA
        tools/collectors/sysmetrics/_init_.py NA
        tools/collectors/sysmetrics/pidstat.py OK
        tools/functions.py OK
        tools/hugepages.py OK
        tools/_init_.py NA
        tools/load_gen/dummy/dummy.py OK
        tools/load_gen/dummy/_init_.py NA
        tools/load_gen/_init_.py NA
        tools/load_gen/load_gen.py OK
        tools/load_gen/stress/_init_.py NA
        tools/load_gen/stress_ng/_init_.py NA
        tools/load_gen/stress_ng/stress_ng.py OK
        tools/load_gen/stress/stress.py OK
        tools/module_manager.py OK
        tools/namespace.py OK
        tools/networkcard.py OK
        tools/opnfvdashboard/_init_.py NA
        tools/opnfvdashboard/opnfvdashboard.py OK
        tools/pkt_fwd/_init_.py NA
        tools/pkt_fwd/pkt_fwd.py OK
        tools/pkt_fwd/testpmd.py OK
        tools/pkt_gen/dummy/dummy.py OK
        tools/pkt_gen/dummy/_init_.py OK
        tools/pkt_gen/_init_.py NA
        tools/pkt_gen/ixia/_init_.py OK
        tools/pkt_gen/ixia/ixia.py OK
        tools/pkt_gen/ixnet/_init_.py OK
        tools/pkt_gen/ixnet/ixnet.py OK
        tools/pkt_gen/moongen/_init_.py NA
        tools/pkt_gen/moongen/moongen.py OK
        tools/pkt_gen/testcenter/_init_.py OK
        tools/pkt_gen/testcenter/testcenter.py OK
        tools/pkt_gen/testcenter/testcenter-rfc2544-rest.py OK
        tools/pkt_gen/testcenter/testcenter-rfc2544-throughput.py EXCLUDED
        tools/pkt_gen/testcenter/testcenter-rfc2889-rest.py OK
        tools/pkt_gen/trafficgen/_init_.py OK
        tools/pkt_gen/trafficgen/trafficgen.py OK
        tools/pkt_gen/xena/_init_.py NA
        tools/pkt_gen/xena/XenaDriver.py OK
        tools/pkt_gen/xena/xena_json.py OK
        tools/pkt_gen/xena/xena.py 9.69
        
        Module tools.pkt_gen.xena.xena
        W:646,34: Use % formatting in logging functions and pass the % parameters as arguments (logging-format-interpolation)
        W:667,38: Use % formatting in logging functions and pass the % parameters as arguments (logging-format-interpolation)
        W:673,24: Use % formatting in logging functions and pass the % parameters as arguments (logging-format-interpolation)
        W:691,39: Use % formatting in logging functions and pass the % parameters as arguments (logging-format-interpolation)
        W:693,39: Use % formatting in logging functions and pass the % parameters as arguments (logging-format-interpolation)
        W:695,39: Use % formatting in logging functions and pass the % parameters as arguments (logging-format-interpolation)
        E:704,20: Instance of 'Xena' has no 'error' member (no-member)
        tools/report/_init_.py NA
        tools/report/report.py OK
        tools/systeminfo.py OK
        tools/tasks.py OK
        tools/teststepstools.py OK
        tools/version.py OK
        tools/veth.py OK
        vnfs/_init_.py NA
        vnfs/qemu/_init_.py NA
        vnfs/qemu/qemu_dpdk_vhost_user.py OK
        vnfs/qemu/qemu_pci_passthrough.py OK
        vnfs/qemu/qemu.py 9.96
        
        Module vnfs.qemu.qemu
        C:104, 0: Wrong continued indentation (add 21 spaces).
        vnfs/qemu/qemu_virtio_net.py OK
        vnfs/vnf/_init_.py OK
        vnfs/vnf/vnf.py OK
        vsperf OK
        vswitches/_init_.py NA
        vswitches/ovs_dpdk_vhost.py OK
        vswitches/ovs.py OK
        vswitches/ovs_vanilla.py OK
        vswitches/utils.py OK
        vswitches/vpp_dpdk_vhost.py OK
        vswitches/vswitch.py OK
        Pylint check has failed. All files must have score 10.

Details

Description

Attachments

Activity

People

Dates